Diff-informed queries: phase 3 (non-trivial locations) #19957
+11,378
−2,082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
d10c
force-pushed
the
d10c/diff-informed-phase-3
branch
from
ff3a4b9 to
95fe462
Compare
d10c
force-pushed
the
d10c/diff-informed-phase-3
branch
3 times, most recently
from
aff62c2 to
6d0ae3a
Compare
| @@ -0,0 +1 @@ | |||
| experimental/Security/CWE-208/TimingAttackAgainstHash/TimingAttackAgainstHash.ql | |||
Check warning
Code scanning / CodeQL
Query test without inline test expectations Warning test
d10c
force-pushed
the
d10c/diff-informed-phase-3
branch
2 times, most recently
from
c871f5e to
276c7f0
Compare
d10c
force-pushed
the
d10c/diff-informed-phase-3
branch
2 times, most recently
from
cb2db2f to
c70036d
Compare
java/ql/lib/semmle/code/java/security/TempDirLocalInformationDisclosureQuery.qll
Fixed
Show fixed
Hide fixed
d10c
force-pushed
the
d10c/diff-informed-phase-3
branch
from
c70036d to
08c4cc2
Compare
d10c
force-pushed
the
d10c/diff-informed-phase-3
branch
2 times, most recently
from
857b583 to
3e3e856
Compare
|
DCA results: some slowdowns on Python, but they don't seem to be related to these changes. Java had some timeout-related failures, so I'll restart that. Overall, no negative performance impact on empty-diff. |
…bably need to add MaD source)
d10c
force-pushed
the
d10c/diff-informed-phase-3
branch
from
443655d to
5112a9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actually selected.
Prior work includes PRs like #19663, #19759, and #19817. This PR uses the same patch script as those PRs to find candidate queries to convert to diff-enabled. This is the final step in mass-enabling diff-informed queries on all the languages.
Commit-by-commit reviewing is recommended.
Potentially tricky cases:
--check-diff-informedlocally and in CI. Should create a follow-up issue.where, or if it's good enough to overapproximate and just pass the--check-diff-informedtests.